added vertical datum to metadata #165
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuukBlom
reviewed
Oct 11, 2024
Comment on lines
+148
to
+151
| vdatum, okay = app.gui.window.dialog_string("Provide a vertical datum for the dataset", "MSL") | ||
| if not okay: | ||
| # Cancel was clicked | ||
| return |
There was a problem hiding this comment.
Should we allow people to enter anything and validate that its an actual vdatum or maybe only select from a list of allowed vdatums?
Not sure about a solution, which ones to allow / how to get them. But allowing any str and not validating might break the app / data catalog when that dataset is used?
There was a problem hiding this comment.
@roeldegoede is this an issue or should I just merge?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For datasets, a vertical_datum should be provided in the metadata of the data_catalog.yml file. For newly added datasets, we check whether it is in the files metadata, otherwise the user should specify it.
Once generating the topobathy of the SFINCS model, we add the vertical datum of the first dataset to the models metadata. This can in the end be found in the "sfincs_build.yaml" file under meta, vertical datum, e.g.:
It isn't used for anything, just for keeping track of the vertical reference level after creating the model. Note, this file is only present for models that are built with the FloodAdapt_ModelBuilders ...